Require QGIS 3.40 (LTR) #2437
Draft
Require QGIS 3.40 (LTR) #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And now it is QString and QDateTime. Makes MyPy happy, and is the documented way to do this. https://doc.qt.io/archives/qt-5.15/qmetatype.html#Type-enum https://docs.qgis.org/3.40/en/docs/pyqgis_developer_cookbook/expressions.html#expressions-with-features (cherry picked from commit 49e3ee4)
(cherry picked from commit ad42906)
Member
|
This is enough to run the tests again, but no output seems to be captured. It needs to be debugged further to understand why. We might need to just move to our own testing setup.
docker exec -t qgis sh -c "wget -P /usr/bin https://raw.githubusercontent.com/qgis/QGIS/refs/tags/ltr-3_40/.docker/qgis_resources/test_runner/qgis_setup.sh && chmod +x /usr/bin/qgis_setup.sh"
docker exec -t qgis sh -c "wget -P /usr/bin https://raw.githubusercontent.com/qgis/QGIS/refs/tags/ltr-3_40/.docker/qgis_resources/test_runner/qgis_testrunner.sh && chmod +x /usr/bin/qgis_testrunner.sh"
docker exec -t qgis sh -c "wget -P /usr/bin https://raw.githubusercontent.com/qgis/QGIS/refs/tags/ltr-3_40/.docker/qgis_resources/test_runner/qgis_startup.py"
docker exec -t qgis sh -c "wget -P /usr/bin https://raw.githubusercontent.com/qgis/QGIS/refs/tags/ltr-3_40/.docker/qgis_resources/test_runner/qgis_testrunner.py"
# [..]
docker exec -t qgis sh -c "apt install -y python3-pandas" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion starting from #2429 (comment).
On main the Mypy failures are avoided by pinning our Pixi QGIS to 3.40. Since it is only a Mypy issue right now, our QGIS plugin continues to support the latest QGIS version (running 3.44 myself currently). Still it would be nice not to have to pin QGIS, and at some point we need to move to newer Docker images anyway.
This is blocked on the new Docker image not having plugin setup scripts, and those in the QGIS repo don't seem to work anymore.
We could also consider going directly to require QGIS 4 if this doesn't get picked up soon. That would probably face the same Docker issue though.